MAINT: Mark type-check-only ufunc subclasses as ufunc aliases during runtime #19958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
added
03 - Maintenance
08 - Backport
Member
Author
|
@BvB93 Ping for check. NumPy 1.21.x still supports Python 3.7. |
BvB93
approved these changes
Sep 26, 2021
Member
BvB93
left a comment
BvB93
left a comment
There was a problem hiding this comment.
LGTM, the changes introduced herein work just as well with 3.7 as with >= 3.8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #19856.
Closes #19834
numpy.typing currently has a number of (type-check-only) ufunc subclasses that are used for differentiation the various combinations of ufunc.nin and ufunc.nout ufuncs. These classes were previously marked as Any during runtime however, which could trip up autocompletion tools such as Jedi.
This issue has been resolved by instead treating them as ufunc aliases during runtime, similar to how typing.TypedDict is treated w.r.t. dict.