Skip to content

DOC: replace return type in np.ma.* docstring - #19899

Merged
melissawm merged 3 commits into
numpy:mainfrom
arunppsg:issue16751_add_note_to_docs
Oct 1, 2021
Merged

melissawm merged 3 commits into
numpy:mainfrom
arunppsg:issue16751_add_note_to_docs

Conversation

@arunppsg

@arunppsg arunppsg commented Sep 20, 2021 •

Copy link
Copy Markdown
Contributor

Fix to issue #16751

Some functions in numpy.ma like clip, diff were not yet using _convert2ma. Code as added for those cases to use _convert2ma.

@arunppsg
arunppsg marked this pull request as draft September 20, 2021 13:29

@HaoZeke HaoZeke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great, however some of these functions are not covered in ma/tests/test_core.py; would you like to add tests for them?

@arunppsg
arunppsg marked this pull request as ready for review September 22, 2021 10:56
@arunppsg arunppsg changed the title DOC: replace return type in np.ma.* docstring #16751 DOC: replace return type in np.ma.* docstring Sep 23, 2021
@arunppsg

Copy link
Copy Markdown
Contributor Author

Just a friendly reminder @HaoZeke :)

@HaoZeke HaoZeke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this! pinging @melissawm for a second pair of eyes :)

@melissawm

Copy link
Copy Markdown
Member

I noticed that there's no html docs for numpy.ma.diff, numpy.ma.ones_like or numpy.ma.zeros_like; do we want to add that? The docstrings look good to me

@HaoZeke

HaoZeke commented Oct 1, 2021

Copy link
Copy Markdown
Member

I noticed that there's no html docs for numpy.ma.diff, numpy.ma.ones_like or numpy.ma.zeros_like; do we want to add that? The docstrings look good to me

We would like that, but perhaps that should be a separate issue and PR?

@melissawm

Copy link
Copy Markdown
Member

Sounds good, let's merge and create a separate issue. Thanks @arunppsg !

@melissawm
melissawm merged commit c783285 into numpy:main Oct 1, 2021
@arunppsg
arunppsg deleted the issue16751_add_note_to_docs branch October 1, 2021 16:47
@rcomer rcomer mentioned this pull request Aug 12, 2022
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants