MAINT: Mark type-check-only ufunc subclasses as ufunc aliases during runtime #19856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BvB93
added
09 - Backport-Candidate
BvB93
force-pushed
the
ufunc-subclass
branch
from
4c00f32 to
739e89d
Compare
Member
|
Thanks Bas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19834
numpy.typingcurrently has a number of (type-check-only) ufunc subclasses that are used for differentiation the various combinations ofufunc.ninandufunc.noutufuncs. These classes were previously marked asAnyduring runtime however, which could trip up autocompletion tools such as Jedi.This issue has been resolved by instead treating them as
ufuncaliases during runtime, similar to howtyping.TypedDictis treated w.r.t.dict.