-
-
Notifications
You must be signed in to change notification settings - Fork 11.9k
MAINT,DOC: Readability improvements and cleanup for f2py #19775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3022b0f to
deb2493
Compare
|
RE: Removing tests ^ Another seemingly potentially aggressive cleaning step, this is a good thing to have before we move forward with the new test suite. |
fe71379 to
f9bdf76
Compare
f9bdf76 to
af5510b
Compare
Are they currently unused? Are you putting together another test set? |
This set is unused. There are Here is an extract of the logic behind this: At the moment it seems like the newer tests use code and suffix to put the fortran source inside the However, the older tests had (IMO) a nicer structure with the source code in a separate f/90 file (even though the older test style can be cleaned up now). As an example of the older test approach it is the one in test_mixed.py or test_common.py (8042526). |
|
In case it is useful for writing tests, Fortran Lang uses fypp templates. I suspect you know that already :) |
|
Thanks @HaoZeke . |
OK. This is ready now. It is essentially a very minor PR to make the code seem less out of date in production by:
numpyLet me know if this is too aggressive.
Closes #19910.