ENH: Add dtype-support to 3 generic/ndarray methods
#19745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 24, 2021 16:18
* `astype` * `getfield` * `view`
BvB93
added
01 - Enhancement
08 - Backport
Member
|
Thanks Bas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #19140
closes #19716
While #19140 was technically an enhancement, the problem was that prior to the PR the incorrect usage of
a typevar would ensure that the new dtype was ignored when using the likes of
ndarray.astype.This PR adds dtype-support to the annotations of the following 3
generic/ndarraymethods:astypeviewgetfield