Skip to content

Conversation

@DWesl
Copy link
Contributor

@DWesl DWesl commented Jul 21, 2021

This was suggested by @seiko2plus for debugging a segfault in the
tests on Cygwin:
#18102 (comment)

Pulled from #18308.

This was suggested by @seiko2plus for debugging a segfault in the
tests on Cygwin:
numpy#18102 (comment)

This test passes on Cygwin, and the whole testsuite has only the
failures I expect from running on Cygwin (see numpy#18102 and numpy#16246).
@seiko2plus seiko2plus added the component: SIMD Issues in SIMD (fast instruction sets) code or machinery label Jul 21, 2021
Copy link
Member

@seiko2plus seiko2plus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@mattip mattip merged commit 28a05b3 into numpy:main Jul 22, 2021
@mattip
Copy link
Member

mattip commented Jul 22, 2021

Thanks @DWesl

@DWesl DWesl deleted the x86-feature-tests-cygwin branch July 22, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 - Testing component: SIMD Issues in SIMD (fast instruction sets) code or machinery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants