BUG: Adjust shallow clone in the gitpod container#19119
BUG: Adjust shallow clone in the gitpod container#19119charris merged 2 commits intonumpy:mainfrom trallard:trallard/patch-gitpod
Conversation
|
I think that |
|
That makes sense - adjusted now. I was going for the minimum to build since the NumPy build in the container is basically to leverage the use of cache. Since when Gitpod creates a new workspace it makes a fresh clone and builds again - but since we already did a quick build in Docker this should take way less time. Anyway, this should be all ready to go, thanks for all the insights @charris |
|
The test failures are unrelated. I still haven't managed to figure out how to interpret git 'revisions'. AFAICT, depth goes down all the reachable branches to that many revisions, but even with that I can't figure where it ends in the main branch. Maybe the merged branches provide shortcuts to where they started in the main branch. |
|
Thanks Tania. |
|
Hmm, this failed, but differently The second hash is this commit, the first is the last commit before this. I wonder if the gitpod repo was current? |
|
The |
|
I've made another fix, see #19132. |
Closes #19103
setup.pywas recently updated to better identify the tags through versioneer (see #19096) which meant the previous shallow clone in the Gitpod Docker container was no longer compatible with how tags are handledReplacing
--depth=1with--depth=20works well enough to fix the issue and still keep the clone shallow enough to not bloat the image