BUG: Fix setup.py to work in maintenance branches.#19096
Merged
mattip merged 1 commit intonumpy:mainfrom May 26, 2021
Merged
Conversation
charris
added
00 - Bug
component: build
09 - Backport-Candidate
mattip
reviewed
May 25, 2021
This fixes setup.py to correctly detect the release status and base version from the full version string provided by versioneer. Before this fix, versions like '1.22.0.dev0+...' were correctly handled, but versions like '1.21.0rc1+...' were not.
charris
force-pushed
the
fix-numpy-version
branch
from
d48f1b3 to
9a37cd9
Compare
Member
Author
|
Made some fixes. Note that the |
Member
|
Thanks @charris |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes setup.py to correctly detect the release status and base
version from the full version string provided by versioneer. Before
this fix, versions like '1.22.0.dev0+...' were correctly handled,
but versions like '1.21.0rc1+...' were not.