Repository navigation
DEP: Ensure the string promotion FutureWarning is raised - #18999
Merged
Merged
Conversation
Promotion errors are currently ignored and instead we use `object` as dtype. This means that the FutureWarning is ignored when raised. It also means that there is no way to opt into "future" behaviour, although arguably, we may want to force `dtype=object` in any case if a promotion error occurred (or some signal at least). Closes numpygh-18721 Addresses numpygh-18425 (Does not actually fix it, but chances are we won't)
Member
|
Thanks @seberg |
Contributor
|
@seberg im going through the affected pandas tests to update our usage. A couple of questions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotion errors are currently ignored and instead we use
objectas dtype. This means that the FutureWarning is ignored when raised.
It also means that there is no way to opt into "future" behaviour,
although arguably, we may want to force
dtype=objectin any caseif a promotion error occurred (or some signal at least).
Closes gh-18721
Addresses gh-18425 (Does not actually fix it, but chances are we won't)