Skip to content

DOC: document how to skip CI jobs - #18343

Merged
mattip merged 2 commits into
numpy:mainfrom
rgommers:ci-skip-docs
Nov 17, 2021
Merged

mattip merged 2 commits into
numpy:mainfrom
rgommers:ci-skip-docs

Conversation

@rgommers

@rgommers rgommers commented Feb 6, 2021

Copy link
Copy Markdown
Member

This is a follow-up to gh-18333.

Self-test: docs get built on CircleCI, so let's skip the other platforms:

[skip github]
[skip azurepipelines]
[skip appveyor]
[skip travis]

@charris

charris commented Feb 6, 2021

Copy link
Copy Markdown
Member

close/reopen

@charris charris closed this Feb 6, 2021
@charris charris reopened this Feb 6, 2021
@charris

charris commented Feb 6, 2021

Copy link
Copy Markdown
Member

A bunch of tests timed out after 72 hours (so they claimed). Not sure what was going on with that.

@mattip

mattip commented Feb 6, 2021

Copy link
Copy Markdown
Member

Something is off.

The skip for azure did not work
Neither did the skip for shippable (which, it turns out, will be turned off in May 2021)
It also seems the github actions CI ran.

@rgommers

rgommers commented Feb 7, 2021

Copy link
Copy Markdown
Member Author

Neither did the skip for shippable (which, it turns out, will be turned off in May 2021)

Oh fun, more CI migration. Guess we're going to Drone for ARM 64 then. Let's not do it before it's necessary, the landscape may have changed again by then.

@rgommers

rgommers commented Feb 7, 2021

Copy link
Copy Markdown
Member Author

The skip for azure did not work

This is expected, see the docs in the PR.

Neither did the skip for shippable

There was no skip for shippable, so this is also as expected.

It also seems the github actions CI ran.

This I did not expect, will look into it.

@charris

charris commented Feb 7, 2021

Copy link
Copy Markdown
Member

Oh fun, more CI migration

I did see a jFrog (new owner of Shippable) app for Github actions in the marketplace. jFrog seems to supply an interface to AWS, Azure, or Google, but I'm not clear on how it should be used.

@mattip

mattip commented Feb 15, 2021

Copy link
Copy Markdown
Member

@rgommers did you figure out why github actions ran?

@rgommers

Copy link
Copy Markdown
Member Author

@rgommers did you figure out why github actions ran?

I didn't, no time to look into it.

Base automatically changed from master to main March 4, 2021 02:05
@charris

charris commented Apr 13, 2021

Copy link
Copy Markdown
Member

We removed Shippable from the CI testing and now rely on TravisCI for arm64 testing.

Comment thread doc/source/dev/development_workflow.rst Resolved

@WarrenWeckesser WarrenWeckesser left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks Ralf.

(I haven't merged because I'm not sure what caused the CirceCI checks to fail.)

@melissawm

Copy link
Copy Markdown
Member

+1 Thanks Ralf.

(I haven't merged because I'm not sure what caused the CirceCI checks to fail.)

Looks like the CircleCI debian image needs to be updated? Not sure why this is only showing up here, though.

This is a follow-up to numpygh-18333.

Self-test: docs get built on CircleCI, so let's skip the other
platforms:

[skip github]
[skip azurepipelines]
[skip appveyor]
[skip travis]
@seberg

seberg commented Oct 20, 2021

Copy link
Copy Markdown
Member

Probably some ancient issue, I just rebased on main, lets see.

@WarrenWeckesser

Copy link
Copy Markdown
Member

I guess we still have the question of why the github actions tests and the Travis CI tests ran for this PR even though a commit includes [skip github] and [skip travis].

[skip github]
[skip travis]
@seberg

seberg commented Oct 20, 2021

Copy link
Copy Markdown
Member

I tried adding

[skip github]
[skip travis]

to the second commit as well at least, lets see if it does something (the docs say azure won't work anyway).

@seberg

seberg commented Oct 20, 2021

Copy link
Copy Markdown
Member

I have to admit, it would be a lot easier if we could have something like [ci skip docs], [ci docs only] and maybe [ci python only] (the latter to skip travis jobs for weird architectures and maybe debug builds when the change is a very simple python change).

But, I suppose that is just dreaming :).

@mattip
mattip merged commit 7e94e1e into numpy:main Nov 17, 2021
@mattip

mattip commented Nov 17, 2021

Copy link
Copy Markdown
Member

Thanks @rgommers. This documents how we hope it works, we can iterate in the future to make it more accurate if something is off.

@rgommers
rgommers deleted the ci-skip-docs branch November 17, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants