BUG: Fix subarray dtype used with too large count in fromfile#17832
Merged
charris merged 1 commit intonumpy:masterfrom Nov 23, 2020
Merged
BUG: Fix subarray dtype used with too large count in fromfile#17832charris merged 1 commit intonumpy:masterfrom
charris merged 1 commit intonumpy:masterfrom
Conversation
This also affects fromtext, although only in the deprecated path. Closes numpygh-17819
charris
added
09 - Backport-Candidate
Member
|
Why not stealing the dtype? |
Member
Author
|
Well, have to hold on to it for the resize (at least that seems like the easiest way). And one of the functions already holds on to it internally anyway, so overall it seemed easier to just not steal at all... And in the end, stealing references tends to just add a bit complexity to understanding code (but that may just be my opinion, I used to even like it sometimes for convenience). |
Member
That it does, especially when the documentation is spotty. I wish Python did less of it. |
Member
|
Lets give it a shot. Thanks Sebastian. |
Member
Author
|
Thanks, sorry there are so many last minute things to wrap up for 1.20... I guess it comes with the it being such a big release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also affects fromtext, although only in the deprecated path.
Closes gh-17819
Turns out stealing references tends to come back to bite you :)... @charris, you will be happy to know that while the test is reliable, it doesn't actually crash reliably on my compter, so there is probably a lot of randomness involved...
I think we can backport this to 1.19.x and should, but I have not checked.