Repository navigation
SIMD, BUG: fix reuses the previous values during the fallback to libc - #17763
Conversation
seberg
left a comment
There was a problem hiding this comment.
Thanks, not fluid with SIMD, but this looks good to me! Also good you noticed the sincos issue. I guess the last test could do an exact check, but probably no good reason either.
|
ping @r-devulap |
|
Wouldn't preventing the store from writing to these elements be a simpler and efficient fix? That is, change |
… access of glibc fallback
yes, sure it will fix it but I just tried to take advantage and slightly improve performance. I removed |
|
actually using |
|
Thanks Sayed. I expect we will be tweaking the SIMD code going forward once it is all working. |
Very surprising to see any measurable difference with just the use of |
closes #17761