Skip to content

BUG: Fix memory leaks found using valgrind - #17755

Merged
mattip merged 3 commits into
numpy:masterfrom
seberg:valgrind-fixes2
Nov 12, 2020
Merged

mattip merged 3 commits into
numpy:masterfrom
seberg:valgrind-fixes2

Conversation

@seberg

@seberg seberg commented Nov 11, 2020

Copy link
Copy Markdown
Member

Includes the commit from gh-17753, so that should be merged first. (splitting out also so that the other remains easier to backport).

There is a small refcount bug introduced when fixing/improving the
buffer export code recently. This fixes it.
@seberg

seberg commented Nov 11, 2020

Copy link
Copy Markdown
Member Author

@seiko2plus just to be sure, the _simd code is really purely for testing, right?

@seberg seberg changed the title TST: Fix memory/refcount leak in _simd test code BUG: Fix memory leaks found using valgrind Nov 11, 2020
@seiko2plus

Copy link
Copy Markdown
Member

@seberg, yes, testing is the main reason behind it but it can be useful in designing large SIMD kernels.

@mattip
mattip merged commit 509b5ae into numpy:master Nov 12, 2020
@mattip

mattip commented Nov 12, 2020

Copy link
Copy Markdown
Member

Thanks @seberg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants