Skip to content

TST: f2py: Add a doctest for getlincoef#17662

Merged
mattip merged 1 commit intonumpy:masterfrom
eric-wieser:test-getlincoef
Oct 29, 2020
Merged

TST: f2py: Add a doctest for getlincoef#17662
mattip merged 1 commit intonumpy:masterfrom
eric-wieser:test-getlincoef

Conversation

@eric-wieser
Copy link
Member

No description provided.

@mattip
Copy link
Member

mattip commented Oct 29, 2020

crackfortran.py is not included in our doc build nor are the doctests run in CI. Trying the doctest locally passes, so putting this in.

@mattip mattip merged commit c5b2676 into numpy:master Oct 29, 2020
@mattip
Copy link
Member

mattip commented Oct 29, 2020

Thanks @eric-wieser

@eric-wieser
Copy link
Member Author

Huh, I thought we found in one of @melissawm's PRs that refguide was still going through this file.

@mattip
Copy link
Member

mattip commented Oct 29, 2020

Currently it does not, at least not via python runtests.py --refguidecheck.

It will if we add f2py.crackfortran to refguidecheck here, but then we will have to fix the non-compliant module docstring and add >>> from numpy.f2py.crackfortran import getlincoef to the new doctest.

xref gh-15845 to replace refguidecheck with a better supported solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants