Thanks for the patch. I think the error handling is still generally wrong in this function. I think we need to aim for the C equivalent of:

file = ...
try:
    fd = npy_PyFile_Dup2(file)
    try:
        PyArray_ToFile(fd)
    finally:
        npy_PyFile_DupClose2(fd)
finally:
    if own:
        npy_PyFile_CloseFile(file)

This would almost certainly be much easier to get right if the contents of the outer try were extracted to a helper function. A finally clause is a PyErr_Fetch followed by an unconditional call to npy_PyErr_ChainExceptions.

Hi @eric-wieser, is there anything else to address for this PR? I believe I've implemented all of your review feedback. Thanks.

Thanks @simon-graham