Repository navigation
ENH: Add ma.full and ma.full_like - #17500
Closed
takanori-pskq wants to merge 3 commits into
Closed
takanori-pskq wants to merge 3 commits into
takanori-pskq wants to merge 3 commits into
Conversation
This reverts commit 97f6a3f.
Member
|
Close/reopen to get fixes from latest master and redo the build |
rossbar
self-requested a review
October 9, 2020 19:23
charris
added
the
56 - Needs Release Note.
Member
|
This needs a release note, see the entries in doc/release/upcoming_changes` for examples of how to do that. The added functions seem reasonable to me. |
Author
|
#17480 also need a release note? |
Member
|
Yes, because ENH indicates that the PR contains options/functions previously unavailable. |
Author
|
Added release note. |
InessaPawson
added
the
triage review
Member
|
I am inclined to close this until we have a clear use case that needs the functionality. |
mattip
added
57 - Close?
Member
|
Closing, see #21998 for more discussion. |
InessaPawson
added
triaged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separated from #17480. See #17480 and #16300