Skip to content

ENH: Add new numpy.ma.* aliases - #17480

Closed
takanori-pskq wants to merge 5 commits into
numpy:mainfrom
takanori-pskq:i13114-add-ma-aliases
Closed

ENH: Add new numpy.ma.* aliases#17480
takanori-pskq wants to merge 5 commits into
numpy:mainfrom
takanori-pskq:i13114-add-ma-aliases

Conversation

@takanori-pskq

@takanori-pskq takanori-pskq commented Oct 7, 2020

Copy link
Copy Markdown

Related to #13114, separated from #16300. Now parameter name fill_value collides in np.ma.full (see #16300 ).

@BvB93

BvB93 commented Oct 7, 2020

Copy link
Copy Markdown
Member

Can you also add the new aliases to numpy/ma/__init__.pyi?
Annotating them as Any (just like the rest) should be fine.

@takanori-pskq

takanori-pskq commented Oct 7, 2020

Copy link
Copy Markdown
Author

Added type annotations.

@takanori-pskq
takanori-pskq force-pushed the i13114-add-ma-aliases branch from 8d1837f to 57d33cf Compare October 7, 2020 14:36
@BvB93 BvB93 mentioned this pull request Oct 7, 2020
Merged
rossbar
rossbar reviewed Oct 7, 2020
View reviewed changes

@rossbar rossbar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full and full_like were the only problematic ones that jumped out to me from my previous review of #16300 (see this comment specifically). ones_like, zeros_like, and the *split functions avoid this problem and have nice tests.

I know you just split this one off from another PR, but I think everything aside from the full* functions is mergeable. If you were willing, the changes related to full* could be reverted/split off elsewhere to prevent that from blocking the rest.

@takanori-pskq takanori-pskq mentioned this pull request Oct 8, 2020
Closed
@rossbar
rossbar self-requested a review October 8, 2020 02:55
@charris charris added 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes component: numpy.ma masked arrays labels Oct 11, 2020
@takanori-pskq
takanori-pskq force-pushed the i13114-add-ma-aliases branch 2 times, most recently from 31ba45d to feeb1f7 Compare October 12, 2020 06:24
@takanori-pskq

takanori-pskq commented Oct 12, 2020

Copy link
Copy Markdown
Author

Added release note.

Base automatically changed from master to main March 4, 2021 02:05
@bsipocz bsipocz mentioned this pull request Jul 16, 2022
Closed
@bsipocz

bsipocz commented Jul 16, 2022

Copy link
Copy Markdown
Member

Closing this PR now as its content is conflicting with main here. The rebased version can be found in #21998.

@bsipocz bsipocz closed this Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rossbar rossbar Awaiting requested review from rossbar

Assignees

No one assigned

Labels

01 - Enhancement 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes component: numpy.ma masked arrays

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@takanori-pskq @BvB93 @bsipocz @rossbar @charris