Skip to content

Change mode of open in func write_file() #17054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jakobjakobson13 wants to merge 1 commit into from
Closed

Change mode of open in func write_file() #17054

jakobjakobson13 wants to merge 1 commit into from
+1 −1

Conversation

@jakobjakobson13
Copy link
Contributor

@jakobjakobson13 jakobjakobson13 commented Aug 11, 2020

See #17012 item 1

@eric-wieser
Copy link
Member

eric-wieser commented Aug 11, 2020

This looks wrong to me - data is unicode.

@jakobjakobson13 jakobjakobson13 mentioned this pull request Aug 11, 2020
Open
35 tasks
@jakobjakobson13
Copy link
Contributor Author

jakobjakobson13 commented Aug 11, 2020

This looks wrong to me - data is unicode.

Okay, I'll close it then.

@eric-wieser
Copy link
Member

eric-wieser commented Aug 11, 2020

Ci seems to agree with me.

In principle, we could use open(..., "w", encoding="utf8"), but I think:

  • We'd need to do that everywhere
  • This is likely to cause trouble on systems which do not use utf8 encoding by default

@jakobjakobson13
Copy link
Contributor Author

jakobjakobson13 commented Aug 11, 2020

Okay.

@jakobjakobson13 jakobjakobson13 deleted the genapi_write_file_mode branch August 18, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakobjakobson13 @eric-wieser