Skip to content

BLD, MAINT: Pin setuptools#16870

Merged
charris merged 3 commits intonumpy:masterfrom
mattip:pin-setuptools
Jul 15, 2020
Merged

BLD, MAINT: Pin setuptools#16870
charris merged 3 commits intonumpy:masterfrom
mattip:pin-setuptools

Conversation

@mattip
Copy link
Member

@mattip mattip commented Jul 14, 2020

All the CI runs except travis use the test_requirements.txt or pyproject.toml, so I moved all the setuptools version requirement to those files.

@mattip mattip changed the title Pin setuptools BLD, MAINT: Pin setuptools Jul 14, 2020
@charris charris merged commit 761d798 into numpy:master Jul 15, 2020
@charris
Copy link
Member

charris commented Jul 15, 2020

Thanks Matti.

@hroncok
Copy link
Contributor

hroncok commented Jul 22, 2020

May I ask why to revert this and avoid setuptools 49.2.0? Is a newer version of setuptools supposed to undo the warning?

@mattip
Copy link
Member Author

mattip commented Jul 22, 2020

According to this comment I think they will change the strategy for the next release. With that, PRs to limit use of distutils, like this suggestion to use packaging.version.parse instead of distutils.version are worth exploring.

@hroncok
Copy link
Contributor

hroncok commented Jul 22, 2020

Thank You.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants