TST: get more info in shippable failures#16851
Conversation
3959089 to
fec65e6
Compare
fec65e6 to
8f54b50
Compare
|
Maybe one more? |
Getting late for me. I'm thinking the real problem is in xdist since this doesn't happen without it. |
|
Close/reopen after gh-16857 |
|
I took the liberty of pushing another fix |
04e3404 to
b7743ce
Compare
|
The point of this warning is that setuptools now vendors its own distutils package, so by importing setuptools it injects setuptools.distutils in sys.modules as if it is the stdlib distutils. So on the one hand we could pin our CI to use setuptools<49.2.0, but then one of the downstream projects might update setuptools and start getting warnings that actually come from numpy. Another choice would be to require setuptools>=49.2.0, and refactor our code to import setuptools.distutils everywhere we import distutils. |
That seems... dangerous. There is probably a good reason for it, but replacing the standard library is darn fragile because of all the issues we are seeing. |
|
So the best course of action for now might be to pin |
I think the best thing to do would be to pin
This is not quite right, because This is one phase of an ongoing project to remove |
I rather avoid making a mess working around this, especially if it get fixed in the long run. I'd be more in favor of pinning the version and removing the workarounds we have already added. Things work now, so we can wait until upstream shakes out. |
|
The best procedure is probably to pin first, then maybe revert the workarounds. |
|
The setuptools version has been pinned. |
Also change pytest-xdist for pytest.