MAINT: setuptools 49.2.0 emits a warning, avoid it#16822
Merged
charris merged 2 commits intonumpy:masterfrom Jul 12, 2020
Merged
MAINT: setuptools 49.2.0 emits a warning, avoid it#16822charris merged 2 commits intonumpy:masterfrom
charris merged 2 commits intonumpy:masterfrom
Conversation
Member
|
Hmm, didn't fix the problem. maybe import in the test? |
5e064a9 to
fe867a5
Compare
Member
Author
|
This time I tested before pushing (a unique idea, I should do it more often). I hope it has a better chance of passing. I also noticed some small C warnings about "warning: function declaration isn't a prototype" so added a |
Member
|
Travis is hopelessly lagged, so just going to put this in since azure passes. Thanks Matti. |
Member
|
EDIT: Fixed in #16828. I still see this that happens during pytest collection Could be in pytest, or maybe pytest is importing some files during collection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setuptools 49.2.0, released today, will now emit a warning if distutils is imported before setuptools. This affects the test_api tests, so pre-emtively import setuptools.