Skip to content

BENCH: Add basic benchmarks for scalar indexing and assignment #16786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattip merged 2 commits into from
Jul 9, 2020
Merged

BENCH: Add basic benchmarks for scalar indexing and assignment #16786

mattip merged 2 commits into from
Jul 9, 2020

Conversation

@seberg
Copy link
Member

@seberg seberg commented Jul 8, 2020

No description provided.

@seberg seberg mentioned this pull request Jul 8, 2020
Merged
seberg
seberg commented Jul 8, 2020
View reviewed changes
anirudh2290
anirudh2290 approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@anirudh2290 anirudh2290 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional benchmarks, LGTM !

@mattip mattip merged commit 86fcce6 into numpy:master Jul 9, 2020
@mattip
Copy link
Member

mattip commented Jul 9, 2020

Thanks @seberg. At some point we may wish to parametrize this by dtype, but let's leave that for a future PR if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@anirudh2290 anirudh2290 anirudh2290 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

01 - Enhancement component: benchmarks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@seberg @mattip @anirudh2290 @charris