BUG: Add extern to PyArrayDTypeMeta_Type declaration#16435
Merged
charris merged 1 commit intonumpy:masterfrom May 29, 2020
Merged
BUG: Add extern to PyArrayDTypeMeta_Type declaration#16435charris merged 1 commit intonumpy:masterfrom
charris merged 1 commit intonumpy:masterfrom
Conversation
This was missing the extern, but pre GCC 10 it seemed to have worked fine without. Closes numpygh-16419
rossbar
approved these changes
May 29, 2020
Contributor
rossbar
left a comment
rossbar
left a comment
There was a problem hiding this comment.
This resolved the build issue on my system with gcc 10.1
Member
|
Thanks Sebastian. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missing the extern, but pre GCC 10 it seemed to have worked
fine without.
Closes gh-16419