Skip to content

Conversation

@Qiyu8
Copy link
Member

@Qiyu8 Qiyu8 commented Apr 27, 2020

Debugging is a critical part of the development process, so its documentation should be more detailed and accurate.

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is an improvement that provides a little more guidance without becoming a full-blown gdb tutorial. There is a missing space that needs to be fixed and some structural issues (i.e. perhaps moving some text around) that can be discussed, but I'm +1 on the changes in principle.

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more minor changes, but otherwise I think this looks good.

@rossbar
Copy link
Contributor

rossbar commented Apr 30, 2020

I'm going to do a quick close/re-open to retrigger the CI

@rossbar rossbar closed this Apr 30, 2020
@rossbar rossbar reopened this Apr 30, 2020
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a more careful look at the diff, it seems that some of the original meaning has been altered a bit in the reorganization of the wording. I think it would be best to try to recapture the original meaning that the user should make sure gdb is installed, and if the Python extensions are also installed then additional Python-specific commands are available.

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't think we're quite nailing the wording - I hope I'm not being too obstinate. I've added a wording suggestion that tries to capture my comments.

IMO the big improvement here is related to the examples you've added.

@Qiyu8 Qiyu8 requested review from anirudh2290 and rossbar May 12, 2020 03:55
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @Qiyu8 for your suggestions in improving the debugging docs! IMO the additions are nice as they help give the user a little more guidance in verifying they have the debugger set up properly for this procedure. I also think the listing of gdb commands is an improvement, even though it's not NumPy/Python specific. We'll see what other reviewers think!

Copy link
Member

@anirudh2290 anirudh2290 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely looks more useful. LGTM!

@mattip mattip merged commit 5294c82 into numpy:master May 13, 2020
@mattip
Copy link
Member

mattip commented May 13, 2020

Thanks @Qiyu8, @rossbar

@thisisamardeep
Copy link

Can some one please guide me how to installed python enabled gdb on windows 10 .?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants