Skip to content

DOC: fix SVD tutorial to pass refguide#15710

Merged
mattip merged 3 commits intonumpy:masterfrom
pdebuyl:fix_userguide_tuto_svd
Mar 5, 2020
Merged

DOC: fix SVD tutorial to pass refguide#15710
mattip merged 3 commits intonumpy:masterfrom
pdebuyl:fix_userguide_tuto_svd

Conversation

@pdebuyl
Copy link
Contributor

@pdebuyl pdebuyl commented Mar 5, 2020

Related to #14970

Fix the file tutorial-svd.rst for refguide_check.py

  • Fix output of type for class ndarray
  • Add traceback for shape mismatch

pytest did not show any whitespace difference in the output.

>>> s @ Vt
Traceback (most recent call last):
...
ValueError: matmul: Input operand 1 has a mismatch in its core dimension 0, with gufunc signature (n?,k),(k,m?)->(n?,m?) (size 1024 is different from 768)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line length > 80. doctest is fine with breaking the detail into multiple lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@mattip mattip merged commit 0c32bb4 into numpy:master Mar 5, 2020
@mattip
Copy link
Member

mattip commented Mar 5, 2020

Thanks @pdebuyl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants