ENH: Add object loops to isnan, isinf, and isfinite #14802
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These just fall back on the corresponding function from the `math` module, which in practice coerces to float
eric-wieser
force-pushed
the
object-isfinite
branch
from
d8976a3 to
dcc65fd
Compare
Fraction.__float__ gives a DeprecationWarning if the division results in a non-builtin float This was never intended as part of the test anyway.
Member
Author
|
Failure is due to |
Member
|
This adds 'O->O'. Do we want 'O->?' as well (see also code comment, link may be broken if resolved, in gh-14800) |
Member
Author
|
Duplicates gh-10820, oops |
Member
Author
|
Closing this one, it has more gaps than the one I link above |
Member
|
@eric-wieser did you mean to close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These just fall back on the corresponding function from the
mathmodule, which in practice coerces to float