API: NaT (arg)min/max behavior #14717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Oct 15, 2019
| } | ||
| #endif | ||
| #if @isdatetime@ | ||
| if (mp == NPY_DATETIME_NAT) { |
Member
There was a problem hiding this comment.
nit: four spaces here not three
eric-wieser
reviewed
Oct 15, 2019
| } | ||
| #else | ||
| #if @isdatetime@ | ||
| if (*ip == NPY_DATETIME_NAT) { |
eric-wieser
changed the title
twsearle
added a commit
to twsearle/forest
that referenced
this pull request
Feb 7, 2020
This is to avoid a change at version 1.18 (PR 14717), which is incompatible with our use of numpy.ma.argmax on a datetime64 array containing `NaT` (not a time) fill values. Specifically, `satellite.py: Locator.find_index` was returning indices at fill value locations. Numpy PR here: numpy/numpy#14717
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12797.
As discussed, we want argmin/argmax/min/max to return
NaTwhen it exists in the array.I modified some previous test cases that ignores
NaT. I also combined theDATETIME_argminfunction with more generalargminfunction. So that it is consistent withargmax.