Repository navigation
ENH: Allow NPY_PKG_CONFIG_PATH environment variable override - #14495
Conversation
|
This needs to be documented somewhere, maybe |
|
I think tests aren't required for this, but docstring updates would indeed be nice, plus perhaps a mention in a separate place in the I'd suggest a note in the |
|
Other than that, change LGTM. |
c99407b to
d2b1e04
Compare
|
I don't see how I can meaninfully add something to ./doc/source/reference/distutils.rst about this. I don't have any desire to or idea for how to add support for NPY_PKG_CONFIG_PATH to add_npy_pkg_config(). |
Allow overriding npy-pkg-config directory using the NPY_PKG_CONFIG_PATH environment variable, making it easier to use numpy in cross-compilation setups.
d2b1e04 to
153fc14
Compare
Agreed. Would be nice to have something there about cross-compiling in general, and then this envvar would fall under that. But given that we don't have it, there's no good place to add anything to in that guide. What you added in the docstring is already quite nice.
It's nice content to have, and it can be found when people search the package for "cross compiling". So let's worry about the rest whenever someone writes up a longer story about cross-compiling.
agreed. that's not what I meant. Merged, thanks @esben! |
Allow overriding npy-pkg-config directory using the NPY_PKG_CONFIG_PATH
environment variable, making it easier to use numpy in cross-compilation
setups.
With this in place, you can arrange for cross-compilation npy-pkg-config files in an alternative
location, and use that instead of the host versions when cross compiling.