Repository navigation
MAINT: Extract raising of MemoryError to a helper function - #14477
Merged
Merged
Conversation
eric-wieser
force-pushed
the
MemoryError-cleanup
branch
from
September 11, 2019 08:05
f68d480 to
5f8553a
Compare
seberg
reviewed
Sep 11, 2019
Some minor cleanup that makes the error handling path take up less space in the main flow
eric-wieser
force-pushed
the
MemoryError-cleanup
branch
from
September 13, 2019 07:26
5f8553a to
2814838
Compare
Member
|
LGTM C/C++ analysis seems stuck. This looks good, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor cleanup that makes the error handling path take up less space in the main flow.
This also fails in a slightly more sensible way if somehow other stuff goes wrong while trying to produce the error message.