Skip to content

BLD: Update RELEASE_WALKTHROUGH and cythonize. - #14404

Merged
charris merged 1 commit into
numpy:masterfrom
charris:update-release-walkthrough
Sep 1, 2019
Merged

BLD: Update RELEASE_WALKTHROUGH and cythonize.#14404
charris merged 1 commit into
numpy:masterfrom
charris:update-release-walkthrough

Conversation

@charris

@charris charris commented Aug 31, 2019

Copy link
Copy Markdown
Member

Make it less likely that the wrong cython version is used for
building or cythonizing NumPy. This is motivated by the upcoming
Python 3.8 release that requires the cython 0.29.13 as of 3.8.0b4.

@charris

charris commented Aug 31, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

I think we should remove the fallback use of the cython command in cythonize and only allow the use of the module installed in the python version used. That lessens the chance of an incorrect cython version being used.

@charris charris mentioned this pull request Aug 31, 2019
Closed
eric-wieser
eric-wieser reviewed Aug 31, 2019
View reviewed changes
Comment thread tools/cythonize.py Resolved
eric-wieser
eric-wieser reviewed Aug 31, 2019
View reviewed changes
Comment thread tools/cythonize.py Resolved
rgommers
rgommers reviewed Aug 31, 2019
View reviewed changes
Comment thread tools/cythonize.py Resolved
@rgommers

rgommers commented Aug 31, 2019

Copy link
Copy Markdown
Member

I think we should remove the fallback use of the cython command in cythonize and only allow the use of the module installed in the python version used. That lessens the chance of an incorrect cython version being used.

That's worth considering indeed. It means we stop treating Cython as a compiler, and make it a build-time dependency like setuptools.

@charris
charris force-pushed the update-release-walkthrough branch 4 times, most recently from a6e9c75 to 65d8249 Compare August 31, 2019 23:50
@charris

charris commented Sep 1, 2019

Copy link
Copy Markdown
Member Author

That's worth considering indeed. It means we stop treating Cython as a compiler, and make it a build-time dependency like setuptools.

I'll wait till this goes in, then submit a PR that removes that.

@mattip

mattip commented Sep 1, 2019

Copy link
Copy Markdown
Member

LGTM. xref gh-14378 which pins all build/test dependencies and will hopefully notify when upstream releases a new version

@charris charris mentioned this pull request Sep 1, 2019
Merged
@charris
BLD: Update RELEASE_WALKTHROUGH and cythonize.
a484293 
Make it less likely that the wrong cython version is used for
building or cythonizing NumPy. This is motivated by the upcoming
Python 3.8 release that requires the cython 0.29.13 as of 3.8.0b4.
@charris
charris force-pushed the update-release-walkthrough branch from 65d8249 to a484293 Compare September 1, 2019 14:57
@charris
charris merged commit 3db7ff6 into numpy:master Sep 1, 2019
@charris
charris deleted the update-release-walkthrough branch September 1, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgommers rgommers rgommers left review comments
@eric-wieser eric-wieser eric-wieser left review comments

Assignees

No one assigned

Labels

32 - Installation Problems installing or compiling NumPy component: build component: documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@charris @rgommers @mattip @eric-wieser