Repository navigation
DOC: fix issue with __new__ usage in subclassing doc. - #14395
Merged
Merged
Conversation
Member
|
Maybe worth a comment? There may be potential confusion between generic python objects and the Python |
eric-wieser
reviewed
Aug 29, 2019
| print('Cls in __new__:', cls) | ||
| print('Args in __new__:', args) | ||
| return object.__new__(cls, *args) | ||
| # The `object` type __new__ method takes a single argument. |
Member
There was a problem hiding this comment.
Perhaps:
Suggested change
| # The `object` type __new__ method takes a single argument. | |
| # The `object` type __new__ method takes no additional arguments. |
Normally you wouldn't count cls / self as one of the arguments
Member
There was a problem hiding this comment.
Or maybe just # do not forward any arguments to object.__new__
There was a problem hiding this comment.
Python's error message disagrees with you:
TypeError: object.__new__() takes exactly one argument (the type to instantiate)
This comment has been minimized.
This comment has been minimized.
Member
|
Rewording doesn't make enough difference to keep this open. Thanks Ralf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-14386.