Repository navigation
BLD: MAINT: change default behavior of build flag appending. - #14250
Merged
Merged
Conversation
Member
Author
|
The test failure on Win py37-32bit-fast is unrelated. I see |
Member
|
The |
mattip
reviewed
Aug 15, 2019
Member
There was a problem hiding this comment.
While the test will no longer warn, I think it is useful to have a test for NPY_DISTUTILS_APPEND_FLAGS. Maybe rework this test to still run but without the warnings?
Member
Author
There was a problem hiding this comment.
there is such a test left, it's right above this one
mattip
reviewed
Aug 15, 2019
Member
|
@rgommers looks like easy fixups here. |
This is a follow-up to numpygh-7427. This can lead to hard to understand build failures, and we've warned that this change was coming for two releases.
rgommers
force-pushed
the
ldflags-append
branch
from
August 20, 2019 21:58
1d991c8 to
6c8ba94
Compare
charris
approved these changes
Aug 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to gh-12551. This can lead to hard to understand
build failures, and we've warned that this change was coming for two
releases.