Skip to content

DOC: mention take_along_axis in choose - #14224

Merged
mattip merged 4 commits into
numpy:masterfrom
colinsnyder:take-along-axis-choose
Aug 15, 2019
Merged

mattip merged 4 commits into
numpy:masterfrom
colinsnyder:take-along-axis-choose

Conversation

@colinsnyder

Copy link
Copy Markdown
Contributor

Addresses #14117

Mentioned take_along_axis in the "See Also" section of choose. I believe I understood the issue and added the correct documentation, but I appreciate any feedback. Thanks.

@colinsnyder

Copy link
Copy Markdown
Contributor Author

Hmm. I'm not sure why it claims I have changed lines much further down in the file. I'll try to fix that.

@seberg

seberg commented Aug 7, 2019

Copy link
Copy Markdown
Member

You can try to fix it, since it is not super nice to have these whitespace only changes, but it is also not a real issue. A lot of editors will (correctly) automatically delete whitespace at the end, so if its not you, its likely that someone else will run into it soon. If you want to be very clean, you could make an STY commit, just to remove the whitespace.

@colinsnyder

Copy link
Copy Markdown
Contributor Author

I may be incorrect, but it actually looks like I somehow removed whitespace at the end of lines, not added? Strange, but as per your comment, I suppose its better that way? Thanks.

Comment thread numpy/core/fromnumeric.py Outdated
--------
ndarray.choose : equivalent method
numpy.take_along_axis : Take values from the input array by matching 1d index
and data slices. May be preferable in the case that 'choices'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines are too long, try to keep them <= 75 chars for documentation. Would be good to shorten the description to one line if possible, a link to the function will be generated and interested folks can click through.

Comment thread numpy/core/fromnumeric.py Resolved
@seberg seberg mentioned this pull request Aug 10, 2019
@mattip

mattip commented Aug 15, 2019

Copy link
Copy Markdown
Member

Closes #14117 since we will not be changing the behaviour of numpy.choose.

The rendered docs look good, and removing the trailing whitespace is harmless. Merging.

Thanks @colinsnyder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants