Repository navigation
ENH: add pyproject.toml - #14053
ENH: add pyproject.toml#14053
Conversation
seberg
left a comment
There was a problem hiding this comment.
I would like to get this in soon to use towncrier (and simplify release notes). I think it is likely that towncrier allows a different name for the file soon (i have a PR open, although it may require tests). So if this creates trouble we can probably easily revert it anyway.
|
Hmmm, from Pauli's mail:
|
|
OK, since nobody spoke up against it. I will put this in to try it out, if it creates downstream issues we can revert it. Towncrier does not seem to be responsive about adding |
|
Oooops, had forgotten about my own comment. Will make an issue to document this :// |
|
In https://issues.apache.org/jira/browse/ARROW-8983 we observed that on Py3:
finishes immediately, while:
takes a while to complete. Could this PR be causing this? If yes: is this something that should be fixed or it's a known behavior and is considered WAI? |
|
Probably related, though not sure if that is expected or not, maybe ask at pip? You can get the old behaviour by using: We don't technically need the |
|
Thank you. Asked in pypa/pip#8387. |
|
Strictly speaking, Numpy does need pyproject.toml if you want to build without having first installed Cython manually, as pre-generated sources are no longer included in the sdist. That |
xref #13908
Add a pyproject.toml file. Needed for towncrier.
This has already hit the mailing list, and met with hesitant approval since it causes
pip install .to do an "isolated build" which may download a new cython, lengthening the build.SciPy has added a pyproject.toml, and it doesn't seem to have caused too much pain.