Skip to content

ENH: implement __skip_array_function__ attribute for NEP-18 #13389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shoyer merged 4 commits into from
May 18, 2019
Merged

ENH: implement __skip_array_function__ attribute for NEP-18 #13389

shoyer merged 4 commits into from
May 18, 2019

Conversation

@shoyer
Copy link
Member

@shoyer shoyer commented Apr 23, 2019

To clarify the implications of #13305

@shoyer shoyer force-pushed the implement-numpy-implementation branch from 247f88b to afda748 Compare April 23, 2019 04:59
@charris charris changed the title ENH: implement __numpy_implementation__ attribute for NEP-18 ENH: implement __skip_array_function__ attribute for NEP-18 May 11, 2019
@shoyer shoyer mentioned this pull request May 11, 2019
Closed
33 tasks
@charris
Copy link
Member

charris commented May 13, 2019

Can remove the draft status after NEP changes are accepted?

@shoyer
Copy link
Member Author

shoyer commented May 13, 2019

Can remove the draft status after NEP changes are accepted?

Yes, will do

@mattip
Copy link
Member

mattip commented May 13, 2019

@shoyer was the work to change public_api to have clearer exceptions turned into a PR?

@charris
Copy link
Member

charris commented May 13, 2019

@mattip I think I already merged that in #13529. Or were you thinking of something else?

mattip
mattip reviewed May 13, 2019
View reviewed changes
numpy/core/overrides.py

public_api.__skip_array_function__ = implementation

return public_api
Copy link
Member

@mattip mattip May 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not merge cleanly after #13529

Copy link
Member Author

@shoyer shoyer May 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@shoyer shoyer marked this pull request as ready for review May 13, 2019 23:29
@shoyer
Copy link
Member Author

shoyer commented May 14, 2019

This is ready for review

@mattip
Copy link
Member

mattip commented May 16, 2019

LGTM

@shoyer
Copy link
Member Author

shoyer commented May 16, 2019

Anyone else want to take a look? Otherwise I'll merge this tomorrow. I have a few small changes building on top of this that I want to get into NumPy 1.17.

@shoyer shoyer merged commit 7495de4 into numpy:master May 18, 2019
@shoyer shoyer deleted the implement-numpy-implementation branch May 18, 2019 17:53
@jakirkham jakirkham mentioned this pull request May 20, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattip mattip mattip left review comments

Assignees

No one assigned

Labels

01 - Enhancement 58 - Ready for review component: numpy._core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shoyer @charris @mattip @seberg