Repository navigation
BUG: Always return views from structured_to_unstructured when possible - #13332
Merged
Merged
Conversation
Member
|
I marked this as a backport candidate. Does that make sense? |
Member
Author
Member
Bad PR? |
Member
Author
|
Whoops, #13334 |
Member
Also applies to unstructured_to_structured While producing correct resutls, the test added in this commit would previously make an unecessary copy, causing the assertion to fail. The cause was `astype` was being asked to convert from a subarray of shape `(x, y)` to one of `(x*y,)`, which it cannot do without making a copy. This changes the approach used to skip the step of flattening subarrays to 1d
eric-wieser
force-pushed
the
fix-subarray-unstructured
branch
from
May 1, 2019 15:56
0aeaac0 to
e6a7e05
Compare
Member
|
Thanks Eric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also applies to unstructured_to_structured
While producing correct results, the test added in this commit would previously make an unnecessary copy, causing the assertion to fail.
The cause was
astypewas being asked to convert from a subarray of shape(x, y)to one of(x*y,), which it cannot do without making a copy.This changes the approach used to skip the step of flattening subarrays to 1d