BLD: Windows absolute path DLL loading #13041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add an Azure CI test to mimic recent Anaconda DLL path resolution restrictions that prevent NumPy imports * patch numpy.core initialization to use absolute DLL path loading to overcome the scenario described above
* Test for DLL pollution in numpy/.libs/ in Azure CI Windows Python 3.6 builds * emit a warning with DLL names when > 1 are present in numpy/.libs/
charris
added
08 - Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #13019.
Alternative to #12994
As discussed in #12667 by @rgommers, this may have the advantage of not bricking SciPy / ecosystem projects since it confines the "guaranteed" openblas-related DLL load to numpy/core instead of the distutils machinery change.