BUG: only override vector size for avx code#12555
Merged
charris merged 1 commit intonumpy:masterfrom Dec 16, 2018
Merged
Conversation
only a fraction of code has avx variants so the size must not be overriden globally. Closes numpygh-12507
juliantaylor
force-pushed
the
fix-avx
branch
from
cdac559 to
81fe95c
Compare
charris
added
00 - Bug
component: numpy._core
09 - Backport-Candidate
Member
|
Fixes the problem for me. Thanks Julian. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only a fraction of code has avx variants so the size must not be
overriden globally.
Closes gh-12507
imo this still needs to be rewritten to have less duplication but this is the quick fix.