Skip to content

MAINT: add warning to numpy.distutils for LDFLAGS append behavior. - #12551

Merged
mattip merged 2 commits into
numpy:masterfrom
rgommers:append-warn
Dec 31, 2018
Merged

MAINT: add warning to numpy.distutils for LDFLAGS append behavior.#12551
mattip merged 2 commits into
numpy:masterfrom
rgommers:append-warn

Conversation

@rgommers

@rgommers rgommers commented Dec 15, 2018

Copy link
Copy Markdown
Member

See gh-7427.

@isuruf given that this is a tweak of your PR, would you mind looking this over?

isuruf
isuruf reviewed Dec 15, 2018
View reviewed changes
Comment thread numpy/distutils/fcompiler/environment.py Resolved
isuruf
isuruf reviewed Dec 15, 2018
View reviewed changes
Comment thread numpy/distutils/fcompiler/environment.py Resolved
@charris charris mentioned this pull request Dec 16, 2018
Closed
@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Dec 16, 2018
@charris charris added this to the 1.16.0 release milestone Dec 16, 2018
@charris

charris commented Dec 16, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Test needs fixing to ignore the warning.

EDIT: Not sure why it is failing.

@charris

charris commented Dec 18, 2018

Copy link
Copy Markdown
Member

Pushing this off until the test failure is resolved.

@mattip

mattip commented Dec 19, 2018

Copy link
Copy Markdown
Member

The failing test, test_fcompiler_flags, is getting tripped up on the new warning. It needs a warning-filter context manager.

@rgommers

rgommers commented Dec 28, 2018

Copy link
Copy Markdown
Member Author

All green finally.

@mattip

mattip commented Dec 29, 2018

Copy link
Copy Markdown
Member

Does the new warning need a mention in the release notes, i.e. does this cause new warnings in scipy or other users of f2py?

@rgommers

rgommers commented Dec 30, 2018

Copy link
Copy Markdown
Member Author

There's already a note on NPY_DISTUTILS_APPEND_FLAGS in the 1.16.0 release notes, and this should not give any warnings for builds of other packages by default, only for cases where users have defined LDFLAGS or another envvar.

@mattip
mattip merged commit 1a43137 into numpy:master Dec 31, 2018
@mattip

mattip commented Dec 31, 2018

Copy link
Copy Markdown
Member

Thanks Ralf

@rgommers
rgommers deleted the append-warn branch December 31, 2018 21:30
@charris charris mentioned this pull request Jan 17, 2019
Merged
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Jan 17, 2019
@charris charris removed this from the 1.16.1 release milestone Jan 17, 2019
@rgommers rgommers mentioned this pull request Aug 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@isuruf isuruf isuruf left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

03 - Maintenance component: numpy.distutils

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rgommers @charris @mattip @isuruf