Skip to content

Conversation

@shoyer
Copy link
Member

@shoyer shoyer commented Oct 14, 2018

@njsmith is this OK by you?

This is exactly #10706, but with another commit that fixes a typo, marks it as "Withdrawn" and adds the brief "Note" at the top linking to NEP-22.

@njsmith
Copy link
Member

njsmith commented Oct 14, 2018

LGTM


{% for nep, tags in neps.items() if tags['Status'] == 'Withdrawn' %}
{{ tags['Title'] }} <{{ tags['Filename'] }}>
{% endfor %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we combine "Withdrawn" together with "Abandoned" and "Rejected" like in the PEP process?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I just missed this. But yes, we can definitely update this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make a new PR

@shoyer shoyer merged commit a77ca97 into numpy:master Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants