Repository navigation
TST: reorder duplicate mem_overlap.c compile - #11849
Merged
Merged
Conversation
* _multiarray_tests unfortunately recompile a shared dependency of the extension they are testing, causing gcov to flag the timestamp differential; the shared dependency remains but the extension is now built AFTER the tests are compiled so that the timestamps match expectations for gcov
Member
|
What is it about gcov that makes this work? |
Member
|
Thanks Tyler. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11790
mem_overlap.cwas being recompiled to build a C test extension aftermem_overlap.cwas already compiled by the C extension it is testing. This PR switches the order of compilation--build the test extension first, and then the library, so thatgcovruns on source files that match the building of the library files, not the files that are testing them.A better design might eventually avoid requiring the diophantine code from
mem_overlapto be used in the test file itself--i.e., find a way to probe the code paths in the library without reusing that dependency.