Repository navigation
Conversation
rgommers
approved these changes
Jul 8, 2018
charris
changed the title
Member
|
Thanks Eric. |
Member
|
I've marked this for a |
Member
Author
|
This is another trivial-port branch that needs no rebase |
Member
|
So we just need to change the base branch? |
Member
|
I think it would be good if you just resubmitted it as a new PR against master. |
Member
Author
|
Yes, just resubmit the PR with the same source branch, but targeting a different base branch. I've gone ahead and done that at #11531 |
Member
Author
|
Marking as a backport to indicate it made it to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new
densityargument is added tohistogramdd. It is an alias for the existingnormedargument and provides commonality with thehistogramfunction in which the incorrectly implementednormedargument has been replaced bydensity.Fixes gh-4371.
Less contentious version of #11397