Repository navigation
MAINT: Append *FLAGS instead of overriding - #11525
Conversation
|
It seems Should have a test somewhere in |
|
small nit - would be nice to have a test of |
How would I do that? capture stdout? |
| try: | ||
| var = ' '.join(var + envvar_contents) | ||
| except TypeError: | ||
| var = ' '.join([var] + envvar_contents) |
There was a problem hiding this comment.
Can you add a comment explaining why the try catch is needed? Specifically, give an example of when var is a list and is a string.
Why was this string / list uncertainty not a problem before?
There was a problem hiding this comment.
This is unnecessary after 65687ff#diff-794348013d3654034275e0453541e969L117
| envvar_contents = [envvar_contents] | ||
| if append and os.environ.get('NPY_DISTUTILS_APPEND_FLAGS', '0') == '1': | ||
| if var is None: | ||
| var = '' |
There was a problem hiding this comment.
Shouldn't this be var = [], in order to avoid an extra space appearing? Does this also remove the need for the try/catch?
|
All looks good now, thanks @isuruf! |
|
Thanks everyone for the reviews |
DOC: update release notes for LDFLAGS append behavior (gh-11525).
charris
changed the title
*FLAGS instead of overriding
|
gh-14250 switches the default behavior to append for 1.18.0 |
Fixes #7427