BUG: fix np.load() of empty .npz file #11522
Conversation
|
Trivial test missing for Should we prevent creating such files during savez()? Was there any discussion around that idea? |
|
@mattip There is no need for a test using As for preventing such files during |
| # to seek past the beginning of the file | ||
| fid.seek(-min(N, len(magic)), 1) # back-up | ||
| if magic.startswith(_ZIP_PREFIX): | ||
| if magic.startswith(_ZIP_PREFIX) or magic.startswith(_ZIP_SUFFIX): |
There was a problem hiding this comment.
Perhaps worth noting that when np.loadtxt receives an empty input file it emits:
UserWarning: loadtxt: Empty input file
I'm not necessarily saying that should happen here, but just thought I'd bring that up in case some consistency with empty file loading is desired across functions. If we did want to do that, one could presumably just adjust the unit test to check for the appropriate warning (and still not allow an exception, obviously).
There was a problem hiding this comment.
@tylerjereddy Loading an empty text file is fundamentally not the same as loading an empty archive. Note that np.load() of a npy file containing a single empty array does not warn. Loading an empty text file is different, because there is really no way to guess what the dtype is supposed to be. Here there's no such problem.
|
@mattip What do you think about merging this? |
|
looks good, thanks |
5 participants
Fixes #9989