BUG: Revert #10229 to fix DLL loads on Windows. #11449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
added
00 - Bug
component: distribution
09 - Backport-Candidate
mattip
reviewed
Jun 29, 2018
numpy/distutils/misc_util.py
Outdated
eric-wieser
reviewed
Jun 29, 2018
numpy/distutils/misc_util.py
Outdated
Member
There was a problem hiding this comment.
Presumably this line is the culprit
Member
Author
There was a problem hiding this comment.
Yes, but there seems to be agreement that that whole change was unneeded, so this does a more complete reversion.
Numpy wheels on Windows were clearing the ctypes path when they loaded the OpenBLAS DLL, leading to failure of DLL loads subsequent to NumPy import because the needed DLLs could not be found. This isn't a straight revert, it restores to the 1.15.x version of the relevant code. Closes numpy#11431.
Member
Author
|
Let's get this in so that we can get some test wheels from the daily builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy on windows wheels was clearing the DLL path on load, leading
to any DLL loads subsequent to the NumPy load.
This isn't a straight revert, it restores to the 1.15.x version of
the relevant code.
Closes #11431.