BUG: Fix segfault on failing __array_wrap__
#11296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
force-pushed
the
fix-array_wrap-segfault
branch
from
9bf5642 to
1d4107a
Compare
charris
approved these changes
Jun 10, 2018
mhvk
approved these changes
Jun 10, 2018
Contributor
mhvk
left a comment
mhvk
left a comment
There was a problem hiding this comment.
Yes, looks good. Will merge.
charris
changed the title
__array_wrap__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Milestoning for 1.15, since we changed the behavior of
__array_wrap__in #10919, so if user code breaks as a result, it needs to not segfault!