MAINT: Small tidy-ups to ufunc_object.c #10988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhvk
reviewed
Apr 27, 2018
Contributor
mhvk
left a comment
mhvk
left a comment
There was a problem hiding this comment.
Modulo the minor comment that is not even strictly part of this PR, this all looks OK. Definitely clearer.
| } | ||
|
|
||
| /* Call the method with appropriate context */ | ||
| args_tup = _get_wrap_prepare_args(full_args); |
Contributor
There was a problem hiding this comment.
Not quite this PR, but while you're at it: there would seem to be no reason to call this every time in the loop; maybe preset args_tup to NULL on top, and here only set it if NULL? I.e.,
if (args_tup == NULL) {
args_tup = _get_wrap_prepare_args(full_args);
if (args_tup == NULL) {
goto fail;
}
}
Member
Author
There was a problem hiding this comment.
I also considered just caching this on the full_args object. Something for another PR, I think.
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #9022
No behavior changes, but makes the
__array_wrap__logic a little clearer.