BUG: Never pass output arguments to __array_wrap__ or __array_prepare__ #10488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes numpygh-10450. The previous behavior for `ufunc(..., out=arr)` is now applied to all calling conventions for `out` - namely, the arg tuple passed into `__array_wrap__` and `__array_prepare__` is `(in1, ..., inN, out1, ..., outN)`. This tuple will contain `None` for absent `out` argument, which is consistent with what already happened for `ufunc(..., out=None)`. This breaks one test that asserts the length of the args tuple is `2` for np.minimum(x, y). However, I'd argue that test was broken anyway, and it has been expanded to cover all cases.
eric-wieser
changed the title
eric-wieser
force-pushed
the
__array_wrap__-no-outputs
branch
from
a283ab2 to
20da6ed
Compare
Member
Author
|
Segfault fixed, hopefully. A little messy unfortunately, but should be fairly straightforward to push upstream to the argument parsing once this is in. |
Member
Author
|
#10919 replaces this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #10470, which ensure that output arguments are never passed to
__array_wrap__or__array_prepare__incontext[1].Done as an additional commit for ease of comparison with #10470, but can be squashed.