Skip to content

diag still read-only #7661

Closed
Closed

Description

@akhmerov

It seems that the promised change of diag/diagonal to return a writeable view was forgotten in 1.10 and 1.11.

Is the fix as easy as changing the flag on creation?

Activity

  1. shoyer commented on May 23, 2016

    @shoyer
    Member

    We put off making this change in 1.10 after getting some significant pushback. See this blog post and the subsequent mailing list discussion (which could be turned up with some searching) for more details.

  2. akhmerov commented on May 23, 2016

    @akhmerov
    Author

    Do you mean this discussion?

    It seems to conclude with something like:

    I would love to do the PR once a decision is reached.

    Perhaps now, almost 1.5 years after the last posts in that discussion and more than 2 years after the release of v1.8 it could be a good time to re-raise the topic. Maybe it's time to do the change it in 1.12?

  3. shoyer commented on May 23, 2016

    @shoyer
    Member

    Yes, that looks like the right discussion. It does look like it petered out without a resolution -- I would suggest re-raising it on the mailing list.

  4. ahaldane commented on Jul 6, 2016

    @ahaldane
    Member

    PR #6054 implements a deprecation warning for this change, by the way. The idea would be to warn in 1.12, then implement in 1.13.

  5. rgommers commented on May 8, 2021

    @rgommers
    Member

    Closing as a duplicate of gh-5407.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions