Skip to content

document the change to .base semantics introduced by Add maskna= and ownmaskna= parameters to np.asarray and friends (6c0ad59) #438

Closed

Description

@certik

Per comment:

6c0ad59#commitcomment-1819948

this change should be documented and added into the release notes.

Activity

  1. njsmith commented on Sep 12, 2012

    @njsmith
    Member

    Those parameters were removed again in #297, so there's nothing to document...

  2. njsmith commented on Sep 12, 2012

    @njsmith
    Member

    Oh, you mean, document the change in the .base parameter that was also included in that commit... sorry.

  3. embray commented on Sep 12, 2012

    @embray
    Contributor

    Right...I don't fully understand what the maskna and ownmaskna parameters are, or how they were meant to be used. But their implementation also included changes to .base, which I'm guessing were necessary anyways. And I remember seeing some mailing list discussions about changing .base to only include arrays that own their data (a change a welcome, which makes walking .base a lot easier and closes some reference cycles that I've had to fight with in my own code).

    But it's sort of unrelated to the original change that it rode in on.

  4. teoliphant commented on Nov 6, 2012

    @teoliphant
    Member

    This is related to issue #470 so I'm closing this one.

  5. certik commented on Nov 14, 2012

    @certik
    ContributorAuthor

    I've added a note about .base into the release notes in PR #2737. Let me know if you think it is sufficient.

  6. embray commented on Nov 14, 2012

    @embray
    Contributor

    Works for me.

  7. added a commit that references this issue on Dec 26, 2012
    a757cb5
  8. certik commented on Dec 27, 2012

    @certik
    ContributorAuthor

    This is now fixed by #2737.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Priority: highHigh priority, also add milestones for urgent issues

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions